`transactions` table: Store `hash` as BYTEA by aditya1702 · Pull Request #495 · stellar/wallet-backend

aditya1702 · 2026-02-05T18:10:03Z

What

This PR updates the codebase to store transactions.hash as BYTEA (raw 32 bytes) in Postgres while keeping the Go/GraphQL-facing representation as a 64-char hex string.

Changes:

Introduces types.HashBytea with sql.Scanner/driver.Valuer implementations and updates types.Transaction.Hash to use it.
Updates transaction ingestion and data-layer inserts/queries to bind hashes as BYTEA/bytea[] (plus corresponding test updates).
Updates GraphQL schema/resolvers so Transaction.hash continues to resolve as a String despite the underlying Go type change.

Why

Storage optimization

Known limitations

N/A

Issue that this PR addresses

Closes #494

Implements Scan, Value, and String methods following the AddressBytea pattern. Stores 32-byte raw SHA-256 hash in database, represents as 64-character hex string in Go.

Changes the Hash field from string to HashBytea for automatic BYTEA serialization/deserialization in the database.

Converts the ingest transaction hash to HashBytea type for proper database serialization.

Converts HashBytea to string for use as map key since HashBytea is not directly comparable as a map key type.

- GetByHash: Convert input hash string to HashBytea for query - BatchInsert: Convert hashes to [][]byte, use bytea[] in SQL, return hex-encoded hashes - BatchCopy: Convert hash to bytes using Hash.Value()

Stores 32-byte raw SHA-256 hash instead of 64-char hex string, reducing storage by ~50%.

Tests for Scan, Value, Roundtrip, and String methods following the same pattern as AddressBytea tests.

All test files now use valid hex strings that can be converted to 32-byte BYTEA values instead of simple strings like "tx1", "tx2".

Copilot

Pull request overview

This PR updates the codebase to store transactions.hash as BYTEA (raw 32 bytes) in Postgres while keeping the Go/GraphQL-facing representation as a 64-char hex string.

Changes:

Introduces types.HashBytea with sql.Scanner/driver.Valuer implementations and updates types.Transaction.Hash to use it.
Updates transaction ingestion and data-layer inserts/queries to bind hashes as BYTEA/bytea[] (plus corresponding test updates).
Updates GraphQL schema/resolvers so Transaction.hash continues to resolve as a String despite the underlying Go type change.

Reviewed changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
internal/db/migrations/2025-06-10.2-transactions.sql	Changes `transactions.hash` column type to `BYTEA` in the migration script.
internal/indexer/types/types.go	Adds `HashBytea` and switches `Transaction.Hash` to `HashBytea`.
internal/indexer/types/types_test.go	Adds unit tests for `HashBytea` Scan/Value/roundtrip/String.
internal/indexer/processors/utils.go	Converts ingested transaction hashes to `types.HashBytea`.
internal/indexer/indexer_buffer.go	Adjusts buffer keying to use `transaction.Hash.String()`.
internal/indexer/indexer_buffer_test.go	Updates buffer tests to use valid 64-char hex hashes.
internal/data/transactions.go	Updates `GetByHash`, `BatchInsert`, and `BatchCopy` to bind hash as `BYTEA`.
internal/data/transactions_test.go	Updates transaction model tests to use valid hex hashes and `HashBytea` comparisons.
internal/data/statechanges.go	Updates tx-hash filtering to bind as `types.HashBytea`.
internal/data/statechanges_test.go	Updates state change tests/fixtures to insert/query `BYTEA` hashes.
internal/data/operations_test.go	Updates operation tests/fixtures to insert `BYTEA` hashes.
internal/data/accounts_test.go	Updates account tests/fixtures to insert `BYTEA` hashes.
internal/services/ingest_test.go	Updates ingest tests to use hex hashes and bind hash params as `HashBytea`/`[]byte`.
internal/serve/graphql/schema/transaction.graphqls	Forces resolver for `Transaction.hash` to keep GraphQL type `String!`.
internal/serve/graphql/resolvers/transaction.resolvers.go	Adds `Hash()` field resolver returning `obj.Hash.String()`.
internal/serve/graphql/generated/generated.go	Regenerates gqlgen output to route `hash` through the new resolver.
internal/serve/graphql/resolvers/test_utils.go	Updates GraphQL test DB setup to insert `types.HashBytea` hashes and adds shared hash constants.
internal/serve/graphql/resolvers/*_test.go	Updates GraphQL resolver tests to compare/use hex hashes via `.String()`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/db/migrations/2025-06-10.2-transactions.sql

internal/serve/graphql/resolvers/transaction_resolvers_test.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

aristidesstaffieri · 2026-02-25T17:27:30Z

internal/data/transactions.go


 	for i, t := range txs {
-		hashes[i] = t.Hash
+		hashBytes, err := t.Hash.Value()


if Hash is empty, the type assertion below will panic. I see that this isn't possible today because the call site(ConvertTransaction) always populates hash but we can be more defensive here against future changes.

aristidesstaffieri · 2026-02-25T17:29:50Z

internal/data/statechanges.go

 	if txHash != nil {
 		queryBuilder.WriteString(fmt.Sprintf(" AND to_id = (SELECT to_id FROM transactions WHERE hash = $%d)", argIndex))
-		args = append(args, *txHash)
+		args = append(args, types.HashBytea(*txHash))


With the column type change from TEXT to BYTEA, invalid hex strings passed as transactionHash from the GraphQL API now produce a driver-level error (from HashBytea.Value()) instead of silently returning empty results. Consider adding input validation at the GraphQL/resolver layer before this reaches the DB.

aditya1702 added 14 commits February 5, 2026 11:03

Add HashBytea type for transaction hash BYTEA storage

c6682d5

Implements Scan, Value, and String methods following the AddressBytea pattern. Stores 32-byte raw SHA-256 hash in database, represents as 64-character hex string in Go.

Update Transaction.Hash field to use HashBytea type

6f73fdf

Changes the Hash field from string to HashBytea for automatic BYTEA serialization/deserialization in the database.

Wrap transaction hash in HashBytea in ConvertTransaction

e743465

Converts the ingest transaction hash to HashBytea type for proper database serialization.

Use .String() for map key in IndexerBuffer

5d16532

Converts HashBytea to string for use as map key since HashBytea is not directly comparable as a map key type.

Update transactions.go for BYTEA hash storage

1ad897d

- GetByHash: Convert input hash string to HashBytea for query - BatchInsert: Convert hashes to [][]byte, use bytea[] in SQL, return hex-encoded hashes - BatchCopy: Convert hash to bytes using Hash.Value()

Change transactions.hash column from TEXT to BYTEA

caacd85

Stores 32-byte raw SHA-256 hash instead of 64-char hex string, reducing storage by ~50%.

Add HashBytea unit tests

a041358

Tests for Scan, Value, Roundtrip, and String methods following the same pattern as AddressBytea tests.

Update test files with valid 64-char hex hashes

4c1e5dc

All test files now use valid hex strings that can be converted to 32-byte BYTEA values instead of simple strings like "tx1", "tx2".

fix tests

09348d9

add resolver for hash

d238b0b

Update statechanges.go

d6526ef

fix all tests

6ff993f

fix more tests

5058261

Update ingest_test.go

6477fa9

aditya1702 changed the title ~~Store hash as BYTEA~~ transactions table: Store hash as BYTEA Feb 5, 2026

aditya1702 requested a review from Copilot February 11, 2026 13:54

Copilot started reviewing on behalf of aditya1702 February 11, 2026 13:54 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

internal/db/migrations/2025-06-10.2-transactions.sql Show resolved Hide resolved

internal/serve/graphql/resolvers/transaction_resolvers_test.go Outdated Show resolved Hide resolved

aditya1702 and others added 2 commits February 20, 2026 14:53

Update internal/serve/graphql/resolvers/transaction_resolvers_test.go

daa2999

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update transaction_resolvers_test.go

396bb61

aristidesstaffieri reviewed Feb 25, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`transactions` table: Store `hash` as BYTEA#495

`transactions` table: Store `hash` as BYTEA#495
aditya1702 wants to merge 16 commits intoaccountid-bytea-txnsfrom
hash-bytea

aditya1702 commented Feb 5, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

aristidesstaffieri Feb 25, 2026

Uh oh!

aristidesstaffieri Feb 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

aditya1702 commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

Known limitations

Issue that this PR addresses

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

aristidesstaffieri Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

aristidesstaffieri Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aditya1702 commented Feb 5, 2026 •

edited

Loading